Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ast): add SymbolId and ReferenceId #755

Merged
merged 12 commits into from
Aug 19, 2023
Merged

feat(ast): add SymbolId and ReferenceId #755

merged 12 commits into from
Aug 19, 2023

Conversation

hyf0
Copy link
Contributor

@hyf0 hyf0 commented Aug 18, 2023

Closes #510

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic labels Aug 18, 2023
hyf0
hyf0 commented Aug 18, 2023
View reviewed changes
crates/oxc_ast/src/ast/js.rs Outdated Show resolved Hide resolved
hyf0
hyf0 commented Aug 18, 2023
View reviewed changes
crates/oxc_ast/src/ast/js.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2023 •
edited
Loading

Codecov Report

Patch coverage: 90.74% and project coverage change: -0.01% ⚠️

Comparison is base (fd3fa6c) 92.24% compared to head (1b74e63) 92.23%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #755      +/-   ##
==========================================
- Coverage   92.24%   92.23%   -0.01%     
==========================================
  Files         202      202              
  Lines       41316    41347      +31     
==========================================
+ Hits        38111    38138      +27     
- Misses       3205     3209       +4
Files Changed Coverage Δ
crates/oxc_semantic/src/reference.rs 70.68% <ø> (ø)
crates/oxc_syntax/src/lib.rs 100.00% <ø> (ø)
crates/oxc_ast/src/ast/js.rs 65.96% <68.75%> (+0.11%) ⬆️
crates/oxc_ast_lower/src/lib.rs 99.36% <100.00%> (ø)
crates/oxc_parser/src/js/binding.rs 98.63% <100.00%> (-0.02%) ⬇️
crates/oxc_parser/src/js/expression.rs 98.37% <100.00%> (ø)
crates/oxc_parser/src/js/function.rs 99.18% <100.00%> (ø)
crates/oxc_parser/src/js/grammar.rs 99.06% <100.00%> (+<0.01%) ⬆️
crates/oxc_parser/src/ts/statement.rs 93.38% <100.00%> (ø)
crates/oxc_semantic/src/binder.rs 98.58% <100.00%> (+0.11%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2023 •
edited
Loading

Benchmark Results

Linux

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.02    250.4±4.26ms    25.5 MB/sec    1.00    246.1±2.22ms    25.9 MB/sec
minifier/react.development.js    1.01      2.6±0.01ms    26.5 MB/sec    1.00      2.6±0.01ms    26.6 MB/sec
minifier/typescript.js           1.05    436.8±4.51ms    23.6 MB/sec    1.00    417.2±4.31ms    24.7 MB/sec
minifier/vue.js                  1.00     16.3±0.25ms    20.0 MB/sec    1.00     16.4±0.35ms    20.0 MB/sec
parser/antd.js                   1.00     77.9±1.03ms    81.8 MB/sec    1.00     78.1±1.06ms    81.7 MB/sec
parser/react.development.js      1.00    861.6±9.13µs    79.9 MB/sec    1.00    862.4±8.78µs    79.8 MB/sec
parser/typescript.js             1.00    132.4±0.34ms    77.9 MB/sec    1.01    133.5±0.33ms    77.3 MB/sec
parser/vue.js                    1.01      5.4±0.05ms    60.2 MB/sec    1.00      5.4±0.03ms    60.6 MB/sec
semantic/antd.js                 1.00     78.2±4.22ms    81.5 MB/sec    1.01     79.3±3.87ms    80.4 MB/sec
semantic/react.development.js    1.00   870.3±22.03µs    79.1 MB/sec    1.00   873.8±22.98µs    78.7 MB/sec
semantic/typescript.js           1.00    170.0±7.67ms    60.7 MB/sec    1.03    175.6±5.25ms    58.8 MB/sec
semantic/vue.js                  1.00      5.9±0.11ms    55.2 MB/sec    1.02      6.0±0.13ms    54.0 MB/sec

Windows

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.04   358.1±12.60ms    17.8 MB/sec    1.00   345.7±16.27ms    18.4 MB/sec
minifier/react.development.js    1.00      3.5±0.09ms    19.9 MB/sec    1.00      3.4±0.11ms    20.0 MB/sec
minifier/typescript.js           1.01   545.5±17.54ms    18.9 MB/sec    1.00   537.9±25.68ms    19.2 MB/sec
minifier/vue.js                  1.00     23.3±1.10ms    14.0 MB/sec    1.02     23.8±0.55ms    13.7 MB/sec
parser/antd.js                   1.00     87.1±3.01ms    73.2 MB/sec    1.02     88.8±3.96ms    71.8 MB/sec
parser/react.development.js      1.00   955.4±21.29µs    72.0 MB/sec    1.02   971.1±41.79µs    70.8 MB/sec
parser/typescript.js             1.00    149.0±3.05ms    69.2 MB/sec    1.02    152.0±7.52ms    67.8 MB/sec
parser/vue.js                    1.00      5.9±0.09ms    55.6 MB/sec    1.02      6.0±0.20ms    54.5 MB/sec
semantic/antd.js                 1.00    108.0±6.81ms    59.1 MB/sec    1.01    108.9±4.43ms    58.6 MB/sec
semantic/react.development.js    1.00  1226.7±34.36µs    56.1 MB/sec    1.07  1314.3±88.41µs    52.3 MB/sec
semantic/typescript.js           1.00   242.7±14.95ms    42.5 MB/sec    1.00   243.7±15.51ms    42.3 MB/sec
semantic/vue.js                  1.00      9.0±0.22ms    36.4 MB/sec    1.05      9.4±0.53ms    34.7 MB/sec

@hyf0 hyf0 force-pushed the hyf_932409230984 branch 2 times, most recently from 4b6d4b1 to faea169 Compare August 18, 2023 16:04
@hyf0 hyf0 marked this pull request as ready for review August 18, 2023 16:04
@hyf0 hyf0 force-pushed the hyf_932409230984 branch from faea169 to 3a9b1d2 Compare August 19, 2023 04:00
@hyf0 hyf0 requested a review from Boshen August 19, 2023 04:25
@hyf0 hyf0 force-pushed the hyf_932409230984 branch from 3a9b1d2 to 2f3e207 Compare August 19, 2023 05:12
Boshen
Boshen reviewed Aug 19, 2023
View reviewed changes
tasks/coverage/src/suite.rs Outdated Show resolved Hide resolved
Boshen
Boshen reviewed Aug 19, 2023
View reviewed changes
tasks/coverage/src/suite.rs Outdated Show resolved Hide resolved
Boshen
Boshen reviewed Aug 19, 2023
View reviewed changes
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice overall, this may lead me to removing the binding logic in hir_lower, I like this.

@hyf0 hyf0 force-pushed the hyf_932409230984 branch from ebaa28f to 1b74e63 Compare August 19, 2023 09:09
@hyf0 hyf0 requested a review from Boshen August 19, 2023 09:55
@Boshen Boshen merged commit e7c2313 into main Aug 19, 2023
@Boshen Boshen deleted the hyf_932409230984 branch August 19, 2023 10:09
@Boshen
Copy link
Member

Boshen commented Aug 19, 2023

Nice work! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Boshen Boshen Boshen approved these changes

Assignees
No one assigned
Labels
A-parser Area - Parser A-semantic Area - Semantic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(ast): add SymbolId and ReferenceId
3 participants
@hyf0 @codecov-commenter @Boshen